Re: Fix Issue 2366 "THANKS needs updating or deleting" (issue 6454140)

[john . mandereau]

Reviewers: Graham Percival, dak,

Message:
On 2012/08/13 09:32:10, dak wrote:
> You have taken the path of removing THANKS altogether if I understand
correctly.

Yes, as I was away from development during late 2.13 and almost all of
2.15 series, I'm not the best person to update THANKS in case we decided
to (I could only do "git shortlog -s" and grep for "thank" in "git
log"), and nobody in position to do it took the effort to update it, so
IMHO this is the route to take.  Otherwise, if we we decide to keep
THANKS, then I'll tag the issue Needs-policy and let's update THANKS at
the meeting in Waltrop if nobody has done it before.


> I am not sure whether we should not replace it by the edited output of
> git shortlog -s release/2.14.2-1..release/2.15.95-1
> instead, manually.  That would cause the least disruption to the code.

Doing so would boil down to updating THANKS as it used to be done, minus
a few entries in Suggestions (see my feeling about keeping THANKS above
in this message).  I think that in this situation "disruption to the
code" or the build system is a wrong motivation to use.

> At any rate, regarding your approach:
Documentation/included/authors.itexi still
> refers to THANKS.  Somewhat surprisingly, so does
> Documentation/hu/web/basic-authors.itexi.

> Also check python/auxiliar/postprocess_html.py.

Oh right, the new patch should address this.

Description:
Fix Issue 2366 "THANKS needs updating or deleting"

Please review this at http://codereview.appspot.com/6454140/

Affected files:
  M Documentation/GNUmakefile
  M Documentation/hu/web/basic-authors.itexi
  M Documentation/included/authors.itexi
  M Documentation/misc/GNUmakefile
  A + Documentation/misc/THANKS-2.14
  M Documentation/web/community.itexi
  M GNUmakefile.in
  M python/auxiliar/postprocess_html.py


Index: Documentation/GNUmakefile
diff --git a/Documentation/GNUmakefile b/Documentation/GNUmakefile
index  
b1c47c1f7950dbc79663ced0ba74a967b4d30b4e..85a0a1de9e1ef97db96342a5901acef141ea5ca3  
100644
--- a/Documentation/GNUmakefile
+++ b/Documentation/GNUmakefile
@@ -27,7 +27,7 @@ $(outdir)/snippets/index.html: TEXI2HTML_FLAGS += -D  
short_toc

 ### Extra source files

-README_TOP_FILES= DEDICATION THANKS
+README_TOP_FILES= DEDICATION

 IN_ITELY_FILES = $(call src-wildcard,snippets/*-intro.itely)
 SNIPPET_LY_FILES = $(call src-wildcard,snippets/*.ly)
Index: Documentation/hu/web/basic-authors.itexi
diff --git a/Documentation/hu/web/basic-authors.itexi  
b/Documentation/hu/web/basic-authors.itexi
index  
99ba226104d6533c2426ec7f271f3ea4b3638fdf..6a298a7750ab9b4a0fd4e50d5e3834d8bf9b8feb  
100644
--- a/Documentation/hu/web/basic-authors.itexi
+++ b/Documentation/hu/web/basic-authors.itexi
@@ -1,5 +1,5 @@
 @c -*- coding: utf-8; mode: texinfo; -*-
address@hidden This file is part of community.itexi and ../topdocs/AUTHORS.itexi
address@hidden This file is part of community.itexi

 @ignore

@@ -7,9 +7,11 @@
   list is sorted alphabetically by surname.  This file lists people
   that have contributed more than a few hours of work.

-  Developers are people who are (or have been) listed under the
-  "Development Team" in the THANKS, and can choose their own
-  titles.  Contributors are everybody else, and simply list their
+  Developers are people who have been listed under the "Development
+  Team" in Documentation/misc/THANKS*, or who are added when they
+  reach a significant amount of contributions with respect to the
+  existing Developers list, and can choose their own titles.
+  Contributors are everybody else, and simply list their
   contributions.  All lists are sorted alphabetically.

   Anybody who has finished doing a "main devel team" task should
Index: Documentation/included/authors.itexi
diff --git a/Documentation/included/authors.itexi  
b/Documentation/included/authors.itexi
index  
9af9e2649d3acb89b299b4f3771276b85ed8c37a..1fb65a5f76fe70fcb2b59e7a167a0e408aeb3480  
100644
--- a/Documentation/included/authors.itexi
+++ b/Documentation/included/authors.itexi
@@ -7,9 +7,11 @@
   list is sorted alphabetically by surname.  This file lists people
   that have contributed more than a few hours of work.

-  Developers are people who are (or have been) listed under the
-  "Development Team" in the THANKS, and can choose their own
-  titles.  Contributors are everybody else, and simply list their
+  Developers are people who have been listed under the "Development
+  Team" in Documentation/misc/THANKS*, or who are added when they
+  reach a significant amount of contributions with respect to the
+  existing Developers list, and can choose their own titles.
+  Contributors are everybody else, and simply list their
   contributions.  All lists are sorted alphabetically.

   Anybody who has finished doing a "main devel team" task should
Index: Documentation/misc/GNUmakefile
diff --git a/Documentation/misc/GNUmakefile b/Documentation/misc/GNUmakefile
index  
b617fc99cd7dc1be42fa10f140a4317659ce5887..d019223ee21988ed5f02b5e747b4c38ed130ea08  
100644
--- a/Documentation/misc/GNUmakefile
+++ b/Documentation/misc/GNUmakefile
@@ -4,7 +4,11 @@ NAME = documentation

 STEPMAKE_TEMPLATES = documentation texinfo

-TEXTS = $(call src-wildcard,ANNOUNCE-*[0-9]) $(call  
src-wildcard,CHANGES-*[0-9]) $(call src-wildcard,ChangeLog*[0-9]) $(call  
src-wildcard,NEWS-*[0-9])
+TEXTS = $(call src-wildcard,ANNOUNCE-*[0-9]) \
+  $(call src-wildcard,CHANGES-*[0-9]) \
+  $(call src-wildcard,ChangeLog*[0-9]) \
+  $(call src-wildcard,NEWS-*[0-9]) \
+  $(call src-wildcard,THANKS-*[0-9])
 EXTRA_DIST_FILES = $(TEXTS)
 EXTRA_DIST_FILES += $(call src-wildcard,*.html)

Index: Documentation/misc/THANKS-2.14
diff --git a/THANKS b/Documentation/misc/THANKS-2.14
similarity index 100%
rename from THANKS
rename to Documentation/misc/THANKS-2.14
Index: Documentation/web/community.itexi
diff --git a/Documentation/web/community.itexi  
b/Documentation/web/community.itexi
index  
d06932a3ff44905ccc32aac598f7a4c9c1e35b42..7a5c746f10e40d61c62c0b655f17062171c4fcc0  
100644
--- a/Documentation/web/community.itexi
+++ b/Documentation/web/community.itexi
@@ -1189,6 +1189,14 @@ Descriptive list of changes by version:
 @divEnd

 @divClass{column-center-bottom}
address@hidden Thanks
+
+Thanks to developers, contributors, bug hunters and suggestions for
address@hidden,releases up to 2.14}.
+
address@hidden
+
address@hidden
 @subheading Changelogs

 Developers' changelogs by version:
Index: GNUmakefile.in
diff --git a/GNUmakefile.in b/GNUmakefile.in
index  
512b8ef598bfc8d2e645df21415501fc2da5010f..3901c55b8bc1f15eaf32a3359e10ec73ae9f139a  
100644
--- a/GNUmakefile.in
+++ b/GNUmakefile.in
@@ -17,7 +17,7 @@ SUBDIRS = python scripts \
 documentation-dir=$(if $(findstring no,$(DOCUMENTATION)),,Documentation)

 SCRIPTS = configure autogen.sh smart-autogen.sh smart-configure.sh
-README_FILES = COPYING COPYING.FDL DEDICATION ROADMAP THANKS HACKING \
+README_FILES = COPYING COPYING.FDL DEDICATION ROADMAP HACKING \
   LICENSE LICENSE.DOCUMENTATION
 TOPDOC_FILES = AUTHORS INSTALL README NEWS
 TOPDOC_TXT_FILES = $(addprefix  
$(top-build-dir)/Documentation/topdocs/$(outdir)/,$(addsuffix .txt,$(TOPDOC_FILES)))
Index: python/auxiliar/postprocess_html.py
diff --git a/python/auxiliar/postprocess_html.py  
b/python/auxiliar/postprocess_html.py
index  
70afde80dcf8278e901cfda710109ed6d3ffbfa0..fd254b5a08411acf4abbb668dcd05b9c710d760a  
100644
--- a/python/auxiliar/postprocess_html.py
+++ b/python/auxiliar/postprocess_html.py
@@ -26,7 +26,6 @@ non_copied_pages =  
['Documentation/out-www/notation-big-page',
                     'out-www/examples',
                     'Documentation/topdocs',
                     'Documentation/bibliography',
-                    'Documentation/out-www/THANKS',
                     'Documentation/out-www/DEDICATION',
                     'input/']