[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fixes position of mensural c clef (issue 6503091)
From: |
PhilEHolmes |
Subject: |
Re: Fixes position of mensural c clef (issue 6503091) |
Date: |
Fri, 07 Sep 2012 20:01:25 +0000 |
http://codereview.appspot.com/6503091/diff/1/mf/parmesan-clefs.mf
File mf/parmesan-clefs.mf (left):
http://codereview.appspot.com/6503091/diff/1/mf/parmesan-clefs.mf#oldcode885
mf/parmesan-clefs.mf:885:
I'm sorry, but I find this incredibly unhelpful. "You've done it wrong"
is insulting to someone who's spent about 40 hours trying to get it
right. The original code was wrong, with any number of incorrect
assumtions. If you could point me to what is incorrect, I'll try to fix
it. I see nothing wrong with the images you've supplied.
http://codereview.appspot.com/6503091/diff/1/mf/parmesan-clefs.mf
File mf/parmesan-clefs.mf (right):
http://codereview.appspot.com/6503091/diff/1/mf/parmesan-clefs.mf#newcode854
mf/parmesan-clefs.mf:854: draw_triple_brevis (exact_center + (0, 1.0
staff_space#),
The mix of tabs and spaces made indentation difficult to follow. Please
explain why mixing tabs and spaces is good.
http://codereview.appspot.com/6503091/diff/1/mf/parmesan-clefs.mf#newcode866
mf/parmesan-clefs.mf:866: 2.2 half_reduced_il# + staff_space# - 2 ypart
exact_center,
I found the line break hindered unserstanding of the syntax, to no
benefit. Most editors extend part 80 characters these days.
http://codereview.appspot.com/6503091/
Re: Fixes position of mensural c clef (issue 6503091), PhilEHolmes, 2012/09/08
Re: Fixes position of mensural c clef (issue 6503091), lemzwerg, 2012/09/08