Re: markup-commands rest-by-number and rest (issue 6850073)

[thomasmorley65]

On 2012/11/30 01:33:08, thomasmorley65 wrote:
> On 2012/11/29 20:42:21, benko.pal wrote:

https://codereview.appspot.com/6850073/diff/7/input/regression/markup-rest-styles.ly
> > File input/regression/markup-rest-styles.ly (right):
> >
> >

https://codereview.appspot.com/6850073/diff/7/input/regression/markup-rest-styles.ly#newcode25
> > input/regression/markup-rest-styles.ly:25: '(-3 -2 -1 0 1 2 3 4 5 6
7))))))))
> > please fix indentation, this and the next list are at quite
different levels.
> > similarly in the other .ly file.

> Couldn't find a guideline to do correct indentation here.
> I ask on -devel

Done.
(Hope so)

> >
https://codereview.appspot.com/6850073/diff/7/input/regression/markup-rest.ly
> > File input/regression/markup-rest.ly (right):
> >
> >

https://codereview.appspot.com/6850073/diff/7/input/regression/markup-rest.ly#newcode27
> > input/regression/markup-rest.ly:27: (if (>= duration 0) dots "")))))
> > this if looks superfluous

> Yep.
> Will delete it.

Done.



https://codereview.appspot.com/6850073/