[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: markup-commands rest-by-number and rest (issue 6850073)
|
From: |
benko . pal |
|
Subject: |
Re: markup-commands rest-by-number and rest (issue 6850073) |
|
Date: |
Tue, 04 Dec 2012 19:49:00 +0000 |
LGTM
https://codereview.appspot.com/6850073/diff/17001/input/regression/markup-rest-styles.ly
File input/regression/markup-rest-styles.ly (right):
https://codereview.appspot.com/6850073/diff/17001/input/regression/markup-rest-styles.ly#newcode18
input/regression/markup-rest-styles.ly:18: (symbol->string style))
sorry for nitpicking, but please don't use tabs. if nothing else is to
be done, I'll be happy to do the formatting.
https://codereview.appspot.com/6850073/diff/17001/input/regression/markup-rest.ly
File input/regression/markup-rest.ly (right):
https://codereview.appspot.com/6850073/diff/17001/input/regression/markup-rest.ly#newcode30
input/regression/markup-rest.ly:30: (number->string (expt 2 duration))
more formatting nitpicking: do we have a line length limit?
https://codereview.appspot.com/6850073/