Re: markup-commands rest-by-number and rest (issue 6850073)

[thomasmorley65]

On 2012/12/04 19:49:00, benko.pal wrote:
> LGTM


https://codereview.appspot.com/6850073/diff/17001/input/regression/markup-rest-styles.ly
> File input/regression/markup-rest-styles.ly (right):


https://codereview.appspot.com/6850073/diff/17001/input/regression/markup-rest-styles.ly#newcode18
> input/regression/markup-rest-styles.ly:18: (symbol->string style))
> sorry for nitpicking, but please don't use tabs.

Thought I had eliminated them.
Done now.
Also, in scm/define-markup-commands.scm

> if nothing else is to be done,
> I'll be happy to do the formatting.

Thanks for the offer. But if you do it for me, I'll never learn how to
do correct.



https://codereview.appspot.com/6850073/diff/17001/input/regression/markup-rest.ly
> File input/regression/markup-rest.ly (right):


https://codereview.appspot.com/6850073/diff/17001/input/regression/markup-rest.ly#newcode30
> input/regression/markup-rest.ly:30: (number->string (expt 2 duration))
> more formatting nitpicking: do we have a line length limit?

I feel the guide-lines for indentation are contradictory.
How to do a good, readable indentation with leveled expressions on a
limited range?
Sometimes there mhas to be a reasonable compromise.

Hope I did it better this time.


https://codereview.appspot.com/6850073/