[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Includes empty skylines in minimum translation calculations (issue 7
|
From: |
k-ohara5a5a |
|
Subject: |
Re: Includes empty skylines in minimum translation calculations (issue 7304068) |
|
Date: |
Sun, 24 Feb 2013 08:18:39 +0000 |
There's some book-keeping error that I can't find. The example at issue
3160 comes out wrong.
https://codereview.appspot.com/7304068/diff/16001/lily/align-interface.cc
File lily/align-interface.cc (right):
https://codereview.appspot.com/7304068/diff/16001/lily/align-interface.cc#newcode65
lily/align-interface.cc:65: an empty extent, delete it from the list
instead. If the extent is
There is no longer any special treatment to empty extents, in this
function.
https://codereview.appspot.com/7304068/diff/16001/lily/align-interface.cc#newcode293
lily/align-interface.cc:293: // gets the same translation as the last
non-empty element before it.
Rather than remove the empty Lines, then put them back in again with the
same 'translate' as the previous, it might be more clear to make one
pass through the array to fill in the missing translates[].
https://codereview.appspot.com/7304068/