[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Includes empty skylines in minimum translation calculations (issue 7
|
From: |
k-ohara5a5a |
|
Subject: |
Re: Includes empty skylines in minimum translation calculations (issue 7304068) |
|
Date: |
Wed, 27 Feb 2013 06:06:43 +0000 |
Also needs some decruftification.
https://codereview.appspot.com/7304068/diff/22001/lily/align-interface.cc
File lily/align-interface.cc (right):
https://codereview.appspot.com/7304068/diff/22001/lily/align-interface.cc#newcode299
lily/align-interface.cc:299: vector<Grob *> non_empty_elems;
The disassembly and reassembly of the array is ridiculous, but with the
comment at least people will not be confused, merely laugh.
https://codereview.appspot.com/7304068/diff/22001/scm/define-grobs.scm
File scm/define-grobs.scm (right):
https://codereview.appspot.com/7304068/diff/22001/scm/define-grobs.scm#newcode2031
scm/define-grobs.scm:2031: (horizon-padding . 100)
You don't need this anymore, and it will terribly confuse some poor
songwriter somewhere, if left in.
https://codereview.appspot.com/7304068/