[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Includes empty skylines in minimum translation calculations (issue 7
|
From: |
address@hidden |
|
Subject: |
Re: Includes empty skylines in minimum translation calculations (issue 7304068) |
|
Date: |
Wed, 27 Feb 2013 12:14:09 +0100 |
On 27 févr. 2013, at 07:06, address@hidden wrote:
> Also needs some decruftification.
>
>
> https://codereview.appspot.com/7304068/diff/22001/lily/align-interface.cc
> File lily/align-interface.cc (right):
>
> https://codereview.appspot.com/7304068/diff/22001/lily/align-interface.cc#newcode299
> lily/align-interface.cc:299: vector<Grob *> non_empty_elems;
> The disassembly and reassembly of the array is ridiculous, but with the
> comment at least people will not be confused, merely laugh.
>
> https://codereview.appspot.com/7304068/diff/22001/scm/define-grobs.scm
> File scm/define-grobs.scm (right):
>
> https://codereview.appspot.com/7304068/diff/22001/scm/define-grobs.scm#newcode2031
> scm/define-grobs.scm:2031: (horizon-padding . 100)
> You don't need this anymore, and it will terribly confuse some poor
> songwriter somewhere, if left in.
Removed.
Thanks for the review!
Cheers,
MS