lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Add the command \offset to LilyPond (issue 8647044)


From: david . nalesnik
Subject: Re: Add the command \offset to LilyPond (issue 8647044)
Date: Tue, 16 Apr 2013 12:41:35 +0000

I've considerably shortened the regtests, removing redundancies and
unnecessary line breaks.  Thanks for the comments!


https://codereview.appspot.com/8647044/diff/1/input/regression/offsets.ly
File input/regression/offsets.ly (right):

https://codereview.appspot.com/8647044/diff/1/input/regression/offsets.ly#newcode11
input/regression/offsets.ly:11:
On 2013/04/13 21:39:41, janek wrote:
generally, i'd make the regtest shorter.

Done.

https://codereview.appspot.com/8647044/diff/1/input/regression/offsets.ly#newcode40
input/regression/offsets.ly:40: <c e g b>1-\offset #'positions #'(-2 .
2) \arpeggio
On 2013/04/13 21:39:41, janek wrote:
for example, one instance of arpeggio should suffice here.

Done.

https://codereview.appspot.com/8647044/diff/1/input/regression/offsets.ly#newcode50
input/regression/offsets.ly:50: \once \offset #'X-offset #0.5
DynamicText
On 2013/04/13 21:39:41, janek wrote:
similarly here

Done.

https://codereview.appspot.com/8647044/diff/1/input/regression/offsets.ly#newcode57
input/regression/offsets.ly:57: c-\offset #'padding #1.5 \f
On 2013/04/13 21:39:41, janek wrote:
ditto

Done.

https://codereview.appspot.com/8647044/diff/1/input/regression/offsets.ly#newcode102
input/regression/offsets.ly:102: \once \offset #'Y-offset #2
BreathingSign
On 2013/04/13 21:39:41, janek wrote:
ditto

Done.

https://codereview.appspot.com/8647044/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]