Re: Isolated durations in music sequences now stand for unpitched notes (issue 22120043)

[Janek Warchoł]

LGTM.

2013/11/13  <address@hidden>:
> On 2013/11/12 21:58:13, janek wrote:
>>
>> 2013/11/12  <address@hidden>:
>> > It still would not be fun in connection with TabStaff, not repeating
>> > string numbers and stuff, and such repetition is really not
>
> feasible.
>
>> I don't understand what you mean here.
>
>
>> > Of course the problem is that we have to make a decision what to
>> > support:
>> >
>> > a) we don't commit ourselves either way: it is undefined what a pure
>> > duration after an intervening chord will do.
>> >
>> > b) just single pitches, no chords: that's what this patch proposes.
>> >
>> > c) also chords: this patch needs more work, supporting code must be
>> > written, Pitch_squash_engraver has to be changed etc etc.
>> >
>> > The problem is that with both options b) and c), we'll soonish have
>> > music depending on this behavior.
>> >
>> > I'm leaning towards a): tell people not to rely on particular
>
> behavior
>>
>> > after a chord for now.
>
>
>> This probably is a good idea.  At least i prefer to a) over b).
>
>
> Ok, I think we'll let this more or less get in in the current form (just
> to get feedback) and I'll do a followup patch that will give a _warning_
> when a raw duration is used after a chord.  Basically this will mean
> that you are not supposed to use
> \new RhythmicStaff { 8 8 4 2 } but rather something like
> \new RhythmicStaff \drummode { tamb 8 8 4 2 }
> which also is nicer in midi.  This would not affect any music commands
> interpreting rhythms: the pitch insertion (which would then complain
> about preceding chords) only runs during scorification.
>
> I am going to rework the documentation/code examples appropriately; I
> don't think that requires restarting the countdown (the examples make
> fewer assumptions in that manner).
>
> https://codereview.appspot.com/22120043/