[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 3917: Add \alternatingTimeSignatures (issue 97110045)
From: |
lilyliska |
Subject: |
Re: Issue 3917: Add \alternatingTimeSignatures (issue 97110045) |
Date: |
Sat, 10 May 2014 22:38:29 +0000 |
https://codereview.appspot.com/97110045/diff/80001/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):
https://codereview.appspot.com/97110045/diff/80001/ly/music-functions-init.ly#newcode144
ly/music-functions-init.ly:144: #{ \once\override
Staff.TimeSignature.stencil =
On 2014/05/10 20:49:09, janek wrote:
Shouldn't this override be at Score level?
Any other ideas?
I have the impression that Staff. works just as well?
https://codereview.appspot.com/97110045/diff/80001/ly/music-functions-init.ly#newcode149
ly/music-functions-init.ly:149: #(map (lambda (x) #{ \markup
\center-column #(map number->string x) #})
On 2014/05/10 20:49:08, janek wrote:
This assumes that the user will input lists of 2 elements. What if
the user
enters just one number, or more than two, for example
\alternatingTimeSignatures
#'((6 1 8)(5)) ? The function should either handle such input
gracefully or
emit a warning/error.
Entering more than two numbers seems gracefully enough:
A column of the given numbers will be created and the first two are used
for the effective time. The result is self-explaining IMO.
But entering only one number will actually fail with an error that
doesn't point the user to the right place or cause. So I agree that this
should be improved.
https://codereview.appspot.com/97110045/
- Re: Issue 3917: Add \alternatingTimeSignatures (issue 97110045), (continued)
- Re: Issue 3917: Add \alternatingTimeSignatures (issue 97110045), lilyliska, 2014/05/09
- Re: Issue 3917: Add \alternatingTimeSignatures (issue 97110045), dak, 2014/05/09
- Re: Issue 3917: Add \alternatingTimeSignatures (issue 97110045), lilyliska, 2014/05/10
- Re: Issue 3917: Add \alternatingTimeSignatures (issue 97110045), lilyliska, 2014/05/10
- Re: Issue 3917: Add \alternatingTimeSignatures (issue 97110045), tdanielsmusic, 2014/05/10
- Re: Issue 3917: Add \alternatingTimeSignatures (issue 97110045), lilyliska, 2014/05/10
- Re: Issue 3917: Add \alternatingTimeSignatures (issue 97110045), janek . lilypond, 2014/05/10
- Re: Issue 3917: Add \alternatingTimeSignatures (issue 97110045),
lilyliska <=
- Re: Issue 3917: Add \alternatingTimeSignatures (issue 97110045), k-ohara5a5a, 2014/05/10
- Re: Issue 3917: Add \alternatingTimeSignatures (issue 97110045), k-ohara5a5a, 2014/05/10
- Re: Issue 3917: Add \alternatingTimeSignatures (issue 97110045), lilyliska, 2014/05/12