|
| From: | dak |
| Subject: | Re: Ready lilypond-mode for packaging for emacs 24 package system, such that lilypond-mode will work wi… (issue 191260043 by address@hidden) |
| Date: | Fri, 26 Dec 2014 18:53:51 +0000 |
https://codereview.appspot.com/191260043/diff/1/elisp/lilypond-mode.el File elisp/lilypond-mode.el (right): https://codereview.appspot.com/191260043/diff/1/elisp/lilypond-mode.el#newcode112 elisp/lilypond-mode.el:112: (progn This progn is unnecessary. The old code gets an OMG from me. https://codereview.appspot.com/191260043/diff/1/elisp/lilypond-mode.el#newcode1165 elisp/lilypond-mode.el:1165: (add-hook 'LilyPond-mode-hook (lambda () (turn-on-font-lock))) (lambda () (turn-on-font-lock)) should just be #'turn-on-font-lock instead. But font-lock-mode is a global preference. I don't think that modes should unconditionally enable it. https://codereview.appspot.com/191260043/
| [Prev in Thread] | Current Thread | [Next in Thread] |