Re: Ready lilypond-mode for packaging for emacs 24 package system, such that lilypond-mode will work wi… (issue 191260043 by address@hidden)

[Peter Schmiedeskamp]

Oops. Good catches. I'll make those edits and resubmit today.

On Mon, Dec 29, 2014 at 8:21 AM, <address@hidden> wrote:

> On 2014/12/29 15:39:40, pschmied wrote:
>
>> Hi all,
>>
>
>  Is there something that I need to do at this point in the system? I
>>
> see the
>
>> comment about the unnecessary `progn` in the code. Should I nix that
>>
> and
>
>> resubmit?
>>
>
> The progn is a style issue but not a show stopper.  However,
> unconditionally enabling font-lock-mode is inappropriate for a mode:
> this should be fixed and resubmitted, and while you are at it, removing
> the progn seems reasonable.
>
> It has the advantage of getting back at the original indentation and
> thus a smaller diff.
>
> Incidentally, it would seem that you have pulled the kill-buffer inside
> of the while loop, a really bad idea.  Without the progn, you'd likely
> have noticed this change.
>
> https://codereview.appspot.com/191260043/
>