lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Create a module variable access system for C++ (issue 249920043 by a


From: nine . fierce . ballads
Subject: Re: Create a module variable access system for C++ (issue 249920043 by address@hidden)
Date: Mon, 29 Jun 2015 23:54:30 +0000

I'd like to study this more, but I don't think I have the time to spend.


https://codereview.appspot.com/249920043/diff/40001/lily/include/lily-modules.hh
File lily/include/lily-modules.hh (right):

https://codereview.appspot.com/249920043/diff/40001/lily/include/lily-modules.hh#newcode39
lily/include/lily-modules.hh:39: Scm_module (const char *name);
explicit?  Implicit construction coupled with implicit conversion to SCM
could lead to surprises.

https://codereview.appspot.com/249920043/diff/40001/lily/include/lily-modules.hh#newcode94
lily/include/lily-modules.hh:94: Module_variable (const char *name, SCM
value = SCM_UNDEFINED)
explicit?

https://codereview.appspot.com/249920043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]