[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (is
From: |
thomasmorley65 |
Subject: |
Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by address@hidden) |
Date: |
Sat, 29 Aug 2015 17:25:44 +0000 |
On 2015/08/23 15:11:08, dak wrote:
https://codereview.appspot.com/257580043/diff/1/scm/fret-diagrams.scm
File scm/fret-diagrams.scm (right):
https://codereview.appspot.com/257580043/diff/1/scm/fret-diagrams.scm#newcode45
scm/fret-diagrams.scm:45: (define (not-number-error input output)
"input" insinuates a port input, like "output" does. The doc string
does not
even mention "output", and from the error message it is supposed to be
an
"unhandled entry in fret-diagram" which would rather seem like some
kind of
input rather than output.
In the new patch-set I deleted this definition, because checking
barre-list with this would have need more additional code. Not worth the
effort.
Instead I used single errors.
https://codereview.appspot.com/257580043/
- Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by address@hidden), thomasmorley65, 2015/08/23
- Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by address@hidden), dak, 2015/08/23
- Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by address@hidden), pkx166h, 2015/08/24
- Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by address@hidden), pkx166h, 2015/08/26
- Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by address@hidden), dak, 2015/08/26
- Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by address@hidden), pkx166h, 2015/08/26
- Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by address@hidden), dak, 2015/08/26
- Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by address@hidden), dak, 2015/08/26
- Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by address@hidden), thomasmorley65, 2015/08/26
- Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by address@hidden),
thomasmorley65 <=
- Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by address@hidden), thomasmorley65, 2015/08/29
- Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by address@hidden), dak, 2015/08/29
- Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by address@hidden), thomasmorley65, 2015/08/29
- Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by address@hidden), pkx166h, 2015/08/30