[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (is
From: |
dak |
Subject: |
Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by address@hidden) |
Date: |
Sat, 29 Aug 2015 18:13:13 +0000 |
On 2015/08/29 17:28:33, thomasmorley651 wrote:
On 2015/08/26 08:55:14, dak wrote:
> https://codereview.appspot.com/257580043/diff/1/scm/lily-library.scm
> File scm/lily-library.scm (right):
>
>
https://codereview.appspot.com/257580043/diff/1/scm/lily-library.scm#newcode793
> scm/lily-library.scm:793: char-set:whitespace))
> A mostly theoretic musing: in the predicates documented in NR, we
have
> `char-whitespace?' listed in "R5RS secondary predicates".
>
> I don't know how it's implemented, but if people compare results,
> char-whitespace? might be the expected point of reference and it's
not like
this
> is performance-critical.
>
> Using that would mean one less function in our codebase for the same
> functionality.
>
> I just thought I'd mention it: it's by no means a necessary change
or even a
> showstopper.
Well, I could use `char-whitespace?' to write a different definition.
Ofcourse a
new definition would still be there.
I've the feeling I don't really understand your proposal...
The proposal is replacing char-set:whitespace with char-whitespace?
which is already being used in LilyPond and advertised to the user.
Just a single-identifier change.
https://codereview.appspot.com/257580043/
- Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by address@hidden), (continued)
- Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by address@hidden), pkx166h, 2015/08/24
- Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by address@hidden), pkx166h, 2015/08/26
- Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by address@hidden), dak, 2015/08/26
- Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by address@hidden), pkx166h, 2015/08/26
- Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by address@hidden), dak, 2015/08/26
- Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by address@hidden), dak, 2015/08/26
- Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by address@hidden), thomasmorley65, 2015/08/26
- Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by address@hidden), thomasmorley65, 2015/08/29
- Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by address@hidden), thomasmorley65, 2015/08/29
- Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by address@hidden),
dak <=
- Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by address@hidden), thomasmorley65, 2015/08/29
- Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by address@hidden), pkx166h, 2015/08/30