|
| From: | nine . fierce . ballads |
| Subject: | Re: Beautify Grob_array and stop using std::vector::data() (issue 264950043 by address@hidden) |
| Date: | Wed, 02 Sep 2015 23:27:40 +0000 |
On 2015/09/02 10:13:26, benko.pal wrote: https://codereview.appspot.com/264950043/diff/40001/lily/include/grob-array.hh#newcode63
lily/include/grob-array.hh:63: // Note: This method may reorder the
array
without affecting the result of what does "reorder" mean in the current context? the function
replaces some
grobs, deletes others.
If the sorting criterion uses attributes of the Grob that are changed by replacement, the array might not be sorted afterward (or might be sorted when it wasn't before). Grob_array does not appear to dictate the sorting criterion. https://codereview.appspot.com/264950043/
| [Prev in Thread] | Current Thread | [Next in Thread] |