Re: Issue 4936: look up "mf" for default initial volume (issue 308890043 by address@hidden)

[dak]

On 2016/08/10 23:05:23, c_sorensen wrote:

> On 8/10/16 4:17 PM, mailto:"address@hidden";
> <mailto:address@hidden> wrote:

> >David, do you have advice on the direction to take regarding the
> >comments on this thing in midi.scm?
> >
> >         (define-public dynamic-default-volume 0.71)
> >
> >To me it seems unnecessary (the user should specify a dynamic if a
> >specific dynamic is desired)

> I'm not David, but I'd like to describe my use case.

> When writing congregational hymns, dynamics are very seldom included.

> But I may wish to generate practice midi from my engraving (I
regularly do
> it).  It would be nice to be able to define my own default midi volume
that
> would apply.

> >and the wrong place for a default anyway.
> >It should be in a context if it needs to be anywhere, right?

> What context would it be defined in?  the midi performer can exist in
a
> variety of contexts.

> I suppose that different contexts might have different default midi
> volumes.

> So I guess the default midi volume might be defined in the Score
context,
> and then any lower contexts could override the default midi volume.
And
> of course, you are right that this should then become a documented
context
> property.

> So at any rate, I think the public definition should be eliminated
from
> midi.scm, regardless of whether or not somebody has used it.

If somebody has used it, it would have had no effect.  I think it is
saner to remove it so that the code trying to set it actually has a
chance to trigger an error (which usually will be dealt with by removing
the ineffectual statement).

With regard to your use case: anything that cannot be dealt with by
using the equivalent of
\score {
  { c'-\hide\ppp }
  \layout {}
  \midi { }
}

\score {
  { g'-\hide\fff }
  \layout {}
  \midi { }
}

Maybe we should also provide the equivalent \loudness "ppp" or so that
only affects Midi (and can stand on its own rather than as an
articulation and thus may also be used in a \midi block)?  At any rate,
this does not appear to affect Dan's patch.  Removing
dynamic-default-volume makes separate sense, and since this patch deals
with default volumes, wrapping its removal into this series would be ok
as well, but it should be a separate commit anyway since it is a
separate identifiable isolated change.

> If eliminating causes them problems, they can add that definition to
their
> ly files.

Well, at some point of time adding mystic incantations that do nothing
at all stops making a lot of sense.  But again: that's not really the
topic of this issue/review.

https://codereview.appspot.com/308890043/