lilypond-user
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Regtest for issue 5181


From: David Kastrup
Subject: Re: Regtest for issue 5181
Date: Sat, 23 Sep 2017 09:49:09 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)

David Kastrup <address@hidden> writes:

> Thomas Morley <address@hidden> writes:
>
>> (define (lily-string->markup str) ...)
>> seems to be unused (same in display-lily-tests.ly) any reason not to
>> delete it?
>
> Oh.  That's the problem with copy&paste jobs.  I'll take a look.

That's -- disconcerting.  This was an oversight in

commit 3950ed69e317c3ecb5d4552f2da7232dd827288f
Author: Han-Wen Nienhuys <address@hidden>
Date:   Sat Jan 6 19:55:38 2007 +0100

    print display-lily-tests results with ly:progress

diff --git a/input/regression/display-lily-tests.ly 
b/input/regression/display-lily-tests.ly
index a6b1dacac7..b492940ddf 100644
--- a/input/regression/display-lily-tests.ly
+++ b/input/regression/display-lily-tests.ly
@@ -34,28 +34,18 @@
     (let ((input (car strings))
          (output (cdr strings)))
      (set! test-number (1+ test-number))
-     (if (string=? input output)
-         (make-music 'SequentialMusic 'void #t)
-         (make-music 'SequentialMusic
-           'elements
-           (list (ly:parser-lookup parser 'fatText)
-                 (make-music 'EventChord
-                   'elements (list (make-music 'LineBreakEvent
-                                     'break-permission 'force)))
-                 (make-music 'EventChord
-                   'elements (list (make-music 'SkipEvent
-                                     'duration (ly:make-duration 0 0 1 1))
-                                   (make-music 'TextScriptEvent
-                                     'direction -1
-                                     'text (markup #:column
-                                            (#:simple (format #f "Test #~a " 
test-number)
-                                             (if (string-null? result-info) 
-                                                 (markup #:bold "BUG") 
-                                                 (markup #:simple result-info))
-                                             #:typewriter (lily-string->markup 
input)
-                                             #:typewriter (lily-string->markup 
output)))))))))))))
-    
+     (if (not (equal? input output))
+         (ly:progress "Test ~a unequal: ~a. \nin  = ~a\nout = ~a\n"
+         test-number
+         (if result-info
+             result-info "BUG")
+          input output))
+
 
+     (make-music 'SequentialMusic 'void #t)
+    
+   ))))
+         
 test = 
 #(define-music-function (parser location result-info strings) (string? pair?)
    (test-function parser location result-info strings))
@@ -64,9 +54,8 @@ test =
 %%% Tests
 %%%
 \header {
-  texidoc = \markup \column { \line { \typewriter display-lily-music unit 
tests }
-                              \line { Real bugs (regressions) are marked as 
\bold BUG. }
-                              \line { Known bugs are marked as TODO. } }
+  texidoc = "This is a test of the display-lily-music unit. Problems are 
reported on the
+stderr of this run." 
 }
 
 \layout {
@@ -260,3 +249,8 @@ test =
 %% Cue notes
 \test "" ##[ \cueDuring #"foo" #1 { c d } #]
 \test "" ##[ \quoteDuring #"foo" { c d } #]
+
+
+%% end test.
+
+#(read-hash-extend #\[ #f) %{ ] %}
which stops the regtest from producing useful printed output.

-- 
David Kastrup

reply via email to

[Prev in Thread] Current Thread [Next in Thread]