Re: [lmi] [PATCH] More XRC fixes, including wxDatePickerCtrl ones

[Vadim Zeitlin]

On Fri, 17 Apr 2015 23:30:25 +0000 Greg Chicares <address@hidden> wrote:

GC> >    This patch doesn't change any behaviour with any
GC> >    version of wxWidgets as wxGROW and wxEXPAND are exactly the same thing.
GC> 
GC> Doesn't the following excerpt from the patch actually change behavior?
GC> 
GC> diff --git a/rounding_view.xrc b/rounding_view.xrc
GC> index c8168ee..39bba29 100644
GC> --- a/rounding_view.xrc
GC> +++ b/rounding_view.xrc
GC> @@ -187,7 +187,7 @@
GC>                      </object>
GC>                  </object>
GC>                  <object class="sizeritem">
GC> -                    
<flag>wxALIGN_LEFT|wxALIGN_TOP|wxBOTTOM|wxLEFT|wxRIGHT|wxEXPAND</flag>
GC> +                    
<flag>wxALIGN_LEFT|wxALIGN_TOP|wxBOTTOM|wxLEFT|wxRIGHT</flag>
GC> 
GC> wxEXPAND was removed altogether--not replaced by wxGROW. But I'm not
GC> going to change anything until all patches have been applied.

 I can only say that unfortunately it shows that I made a mistake again, I
seem to have some real problem with this rounding_view.xrc file. You're
absolutely right and it does change the behaviour, one of wxEXPAND and
wxALIGN_TOP does have to be removed, but it's not clear at all that it had
to be wxEXPAND. Looking at this sizer element again now it seems like it
doesn't grow in the vertical direction anyhow as none of the elements
inside the nested wxFlexGridSizer have wxGROW flag, nor would it make sense
to use it there as they're just buttons and labels. But this post-factum
explanation doesn't change the fact that the change above was unintentional
and shouldn't have been part of this patch, thank you for noticing it and
sorry for failing to do it myself.

 And, of course, also thank you for applying all the patches!
VZ