Re: [lmi] [PATCH] More XRC fixes, including wxDatePickerCtrl ones

[Greg Chicares]

On 2015-04-17 23:44, Vadim Zeitlin wrote:
> On Fri, 17 Apr 2015 23:30:25 +0000 Greg Chicares <address@hidden> wrote:
[...]
> GC> Doesn't the following excerpt from the patch actually change behavior?
> GC> 
> GC> diff --git a/rounding_view.xrc b/rounding_view.xrc
> GC> index c8168ee..39bba29 100644
> GC> --- a/rounding_view.xrc
> GC> +++ b/rounding_view.xrc
> GC> @@ -187,7 +187,7 @@
> GC>                      </object>
> GC>                  </object>
> GC>                  <object class="sizeritem">
> GC> -                    
> <flag>wxALIGN_LEFT|wxALIGN_TOP|wxBOTTOM|wxLEFT|wxRIGHT|wxEXPAND</flag>
> GC> +                    
> <flag>wxALIGN_LEFT|wxALIGN_TOP|wxBOTTOM|wxLEFT|wxRIGHT</flag>
> GC> 
> GC> wxEXPAND was removed altogether--not replaced by wxGROW. But I'm not
> GC> going to change anything until all patches have been applied.
> 
>  I can only say that unfortunately it shows that I made a mistake again, I
> seem to have some real problem with this rounding_view.xrc file. You're
> absolutely right and it does change the behaviour, one of wxEXPAND and
> wxALIGN_TOP does have to be removed, but it's not clear at all that it had
> to be wxEXPAND. Looking at this sizer element again now it seems like it
> doesn't grow in the vertical direction anyhow as none of the elements
> inside the nested wxFlexGridSizer have wxGROW flag, nor would it make sense
> to use it there as they're just buttons and labels.

I don't know what more we could learn just by looking at the xml, so as a
last resort I ran the program to see what it actually does...and this just
doesn't seem to matter at all: the controls seem to have a fixed size and
position within a constant rectangular area that's always centered in the
window. So I think we can conclusively mark this one as "not a defect".