Re: [lmi] [PATCH] More XRC fixes, including wxDatePickerCtrl ones

[Vadim Zeitlin]

On Sat, 18 Apr 2015 19:43:05 +0000 Greg Chicares <address@hidden> wrote:

GC> >  I am sorry if this was unclear, but the patches introducing the use of
GC> > wxGROW in combination with wxALIGN_XXX do require the latest wxWidgets 
with
GC> > my changes allowing this.
GC> 
GC> I think I'd better answer this part right away. My wx build is
GC> 2f239930eb3bc8a928a771d4659e46900907b11f, from around the end of
GC> February:
GC>   http://lists.nongnu.org/archive/html/lmi/2015-02/msg00022.html
GC> That is the version we plan to release into production at the
GC> end of this month.

 If it's impossible to upgrade to the current wxWidgets version, then the
patches relying on wxGROW working in combination with wxALIGN_XXX flags in
2D sizers, i.e. revisions 6173 and 6175 would need to be reverted. And
while r6174, which actually fixes the real problem that triggered all these
changes, i.e. date picker controls being too small to show their contents
fully, could be kept, in principle, it would break the alignment of text
controls with the date picker ones without these changes and so probably
needs to be reverted as well.

GC> Personally, I plan to update wx on my local machine only, but I
GC> was waiting until your high-DPI changes to wx were complete.

 Sorry for the misunderstanding, while I did realize that I was running too
late with the high-DPI fixes for this month release, I still thought that
my wxGROW fixes, which were completed and checked in before April 10, would
find a way into it and this is why I posted the patches requiring these
changes.

 If at all possible, I still think it would be preferable to upgrade to the
current wxWidgets version to get these changes as it would save on the work
needed to revert -- and then, hopefully, apply again -- the already applied
patches and would also fix the actual problem with date picker controls
being too small. But if not, then r6173..6175 need to be reverted.

 Regards,
VZ