Re: [lmi] wxART_* icons not found

[Greg Chicares]

On 2015-11-17 02:34, Vadim Zeitlin wrote:
> On Mon, 16 Nov 2015 03:02:34 +0000 Greg Chicares <address@hidden> wrote:
[...]
> GC> Unable to find icon 'wxART_ERROR' for current theme. Please report this 
> problem.
> GC> A blank icon will be used instead.
> GC> [file /lmi/src/lmi/icon_monger.cpp, line 192]
> 
>  I can reproduce this

Oddly, now I can't reproduce it myself without the just-applied patch.
Perhaps wx has been fortified against this mistake? Even if I 'rm' one
of lmi's icons, I get a messagebox with an 'x'-in-circle icon, which
would seem to be 'wxART_ERROR'.

> and I think the code in icon_monger.cpp is just
> wrong: the comment there implies that it should do nothing for a standard
> icon if it's not found in the map containing lmi-specific overrides, but it
> actually does do something, namely proceeds with the rest of the function
> execution and so generates the (wrong) warning above.

Reference:
  https://github.com/vadz/lmi/pull/17/
Committed 20160511T2003Z, revision 6579.

>  Personally I'd also get rid of the ugly "catch(...)" and apply a more
> extensive patch in the attachment which gets rid of map_lookup() too.

Agreed.