Re: [lmi] Group-quote PDF: whitespace changes, and enhancement

[Vadim Zeitlin]

On Mon, 12 Mar 2018 11:41:07 +0000 Greg Chicares <address@hidden> wrote:

GC> On 2018-03-09 11:32, Vadim Zeitlin wrote:
GC> > On Fri, 9 Mar 2018 02:50:58 +0000 Greg Chicares <address@hidden> wrote:
GC> [...]
GC> > GC> major issue is whether these "999..." fields apply only to a single
GC> > GC> page, or are generic (i.e. so that the same width would be used for
GC> > GC> a user-designed supplemental report).
GC> > 
GC> >  All supplemental report columns currently use "999,999" to compute their
GC> > width, which is surely wrong in the light of this discussion. For now I
GC> > think we have no choice but to replace it with "999,999,999", but in the
GC> > future I think we should consider to defining the columns metadata in one
GC> > place and using it from both standard_supplemental_report (where this
GC> > "999,999" is currently hard-coded) and the other page classes.
GC> 
GC> Is there currently a place where column metadata is stored, so that we
GC> could update it there? Or are you saying that ideally there would be
GC> such a place, but today there is not?

 Yes, exactly. I think we should have a map with the field names as keys
and their names and maximal width as values, but currently we don't have
such a global map.

GC> > GC>   ,{ "ErGrossPmt"           , "ER Gross\nPayment"          ,     
"999,999" }
GC> > GC>   ,{ "EeGrossPmt"           , "EE Gross\nPayment"          ,     
"999,999" }
GC> > GC>   ,{ "GrossPmt"             , "Premium\nOutlay"            , 
"999,999,999" }
GC> 
GC> Where did the widths above (e.g., "999,999") come from? Were they taken
GC> from somewhere in the old XSL-FO code? Or were they initial guesses
GC> based on examining sample output?

 I don't remember exactly any longer, but I think they were just guesses.
VZ