RE: [Ltib] nb31xx platform patch for review

[Kevin Wells]

Hi Miguel,

Technically, everything looks good. Thanks for adding a new
LPC31xx based platform. Looks good!

>+    config EA3131_V1 
>+        bool "Without ethernet"
>+
>+    config EA3131_V2
>+        bool "With ethernet enabled on SRAM1, and int on NAND_RYBN3"
Do you have boards with and without the Ethernet interface? This was
something unique to EA boards (a few early boards didn't have Ethernet).
All new EA boards have Ethernet now.

>+    default "apex-1.6.8-nb31xx" if BOOTLOADER1
>+    default "u-boot-2009.11-lpc31xx" if BOOTLOADER2
>+    default "kernel-2.6.28.2-lpc313x-nb31xx" if EA_KERNEL_2_6_28_2
I notice you are using custom specs for Apex and the 2.6.28 kernel,
but you are using the lpc31xx spec for u-boot. We do occasionally
push new patches up for the u-boot - this may affect you at a later
date as we only test on the EA31xx boards. I actually prefer the
use of the custom board spec instead of trying to merge the patch
into the lpc31xx spec, but as we release new patches, you'll have to
check out and add the patches to your spec files.

You can change the packager name for your new specs to your name.
You might also change the spec summary to indicate the new board.
Maybe in main.lkc too..

thanks,
Kevin

> -----Original Message-----
> From: address@hidden [mailto:ltib-
> address@hidden On Behalf Of Miguel Angel Ajo
> Pelayo
> Sent: Friday, November 12, 2010 5:10 AM
> To: address@hidden; Stuart Hughes
> Subject: [Ltib] nb31xx platform patch for review
> 
> 
> The first patch is here:
>       http://pkgs.nbee.es/nb31xx/ltib/ltib_nb31xx_v1.patch
> 
> And I have a couple of doubts:
> 
>     1) I have included a new script command in bin/ for the ltib
> platform, it's called "deploysd.sh" Is it ok?
> it's meant to mount a rootfs.ext2.gz image using a loop device, and
> making a copy to an SD card, for
> systems that have root filesystem on SD card.
> 
>     2) Under the nb31xx directory I've setup some binary files that will
> be copied to the lib/firmware directory
> of the platform, all of them are for running wireless devices over USB.
> 
>          Should we setup a separate package? or keep those files out of
> ltib main site?, is ist already in some package?
> 
>     I think that's all :)
> 
> Thanks again!
> 
> --
> Miguel Angel Ajo Pelayo
> +34 636 52 25 69
> skype: ajoajoajo
> http://www.nbee.es
> 
> 
> 
> _______________________________________________
> LTIB home page: http://ltib.org
> 
> Ltib mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/ltib