[lwip-devel] [task #7040] Work on tcp_enqueue

[Simon Goldschmidt]

Follow-up Comment #25, task #7040 (project lwip):

> When you say "merged tcp_write with tcp_enqueue_data" I'm a 
> little confused - perhaps I should look at the change - as 
> tcp_write sometimes will want to enqueue flags and data.

I don't think so: tcp_write always enqueued data - sometimes together with
apiflags or options, but never with (tcp-header-)flags: SYN/FIN are now
covered by tcp_enqueue_flags, RST is sent directly, ACK is added in
tcp_output.

Of course I'm still happy for someone else to review the code!

> One thing to check if you're concerned about breaking things is 
> if the TCP timestamp option code still works.

I already tested that and it still works ;-)

The only remaining big function is tcp_write. And although I also thing that
function is too long, it will be difficult to split it into smaller parts as
many local vars are used... I'll see what I can do.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?7040>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/