[lwip-devel] [patch #7264] protocols are rejected incorrectly on big endian architectures

[Greg Renda]

URL:
  <http://savannah.nongnu.org/patch/?7264>

                 Summary: protocols are rejected incorrectly on big endian
architectures
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: greg
            Submitted on: Fri 30 Jul 2010 11:27:02 PM GMT
                Category: None
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None

    _______________________________________________________

Details:

An unrecognized protocol isn't rejected properly when BYTE_ORDER !=
LITTLE_ENDIAN.  The protocol id isn't copied into the output buffer.

--- ppp.c.orig  2010-07-30 16:24:12.000000000 -0700
+++ ppp.c       2010-07-30 16:24:28.000000000 -0700
@@ -1704,8 +1704,8 @@
       }
 #if BYTE_ORDER == LITTLE_ENDIAN
       protocol = htons(protocol);
-      SMEMCPY(nb->payload, &protocol, sizeof(protocol));
 #endif /* BYTE_ORDER == LITTLE_ENDIAN */
+      SMEMCPY(nb->payload, &protocol, sizeof(protocol));
       lcp_sprotrej(pd, nb->payload, nb->len);
     }
     break;





    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?7264>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/