Re: [lwip-users] Fast retransmit

[Sam Jansen]

K.J. Mansley wrote:
> On Tue, 2004-07-13 at 11:28, K.J. Mansley wrote:
>
> I've had another look, and there seems to be a number of things that
> aren't quite right.

> The answer would seem to be that when tcp_rexmit is called from the
> fast retransmit code, it moves *all* unacked segments to the unsent
> queue, which will mean *all* unacked segments are retransmitted.  This
> is not what should happen.

This is the conclusion I came to when looking at the code. I was 
unfamiliar enough with the code to not be sure though.

> <snip>
> I've implemented these changes, but I'm not in a position to test it,
> and it's the sort of thing that could have unforeseen effects.  If I
> check this in, would anyone (perhaps Sam Jansen?) be willing to have
> another look over it and make sure it's behaving properly?

Yeah, I'll check out CVS later today and have a look.

> Also, if anyone has objections to this change, speak now!

Sounds good to me.

--
Sam Jansen                                           address@hidden
Wand Network Research Group             http://www.wand.net.nz/~stj2