Re: [lwip-users] Fast retransmit

[Sam Jansen]

K.J. Mansley wrote:
> OK, I have now, I think, checked this in to HEAD.
>
> Thanks, and let me know if anyone encounters any problems that might be
> related.

Yep, it makes it segfault. I tracked down the problem to a small logical 
error introduced in the latest updates. Attached is a diff to fix it 
(just a one-liner!). Once I fixed this lwip works as expected without 
the previous funky retransmit behaviour.

--
Sam Jansen                                           address@hidden
Wand Network Research Group             http://www.wand.net.nz/~stj2

Index: src/core/tcp_out.c
===================================================================
RCS file: /cvsroot/lwip/lwip/src/core/tcp_out.c,v
retrieving revision 1.35
diff -u -r1.35 tcp_out.c
--- src/core/tcp_out.c  14 Jul 2004 09:48:27 -0000      1.35
+++ src/core/tcp_out.c  14 Jul 2004 22:26:56 -0000
@@ -580,6 +580,7 @@
   /* Move the first unacked segment to the unsent queue */
   seg = pcb->unacked->next;
   pcb->unacked->next = pcb->unsent;
+  pcb->unsent = pcb->unacked;
   pcb->unacked = seg;
 
   pcb->snd_nxt = ntohl(pcb->unsent->tcphdr->seqno);