Re: [lwip-users] ppp-new IP forwarding only works one direction (Ethernet to PPP)

[Sylvain Rochet]

Hello,

On Thu, Apr 10, 2014 at 08:44:43PM +0200, S G wrote:
> 
> Sylvain Rochet wrote:
> > PPPoE use PBUF_LINK, PPPoL2TP use PBUF_TRANSPORT, PPPoS use PBUF_RAW, it 
> > all makes sense at first sight and IP forwarding should work for PPPoE 
> > and PPPoL2TP. Maybe we should allocate a PBUF_LINK for PPPoS as well.
> 
> That would be a good idea for the forwarding case, I guess. However, 
> for ppp rx only, RAM would be wasted. But it should probably fix the 
> current issue.

I put the PPP header into the allocated space for PBUF_LINK if there is 
enough space to do so, for a 14 byte PBUF_LINK_HEADER this is 12 bytes 
of RAM wasted for NO_SYS=1, and 8 bytes for NO_SYS=0 with 32 bits 
pointers, for me this is an acceptable outcome.

Sylvain

signature.asc
Description: Digital signature