[Lynx-dev] SOCK5 crash+fix

[Gisle Vanem]

While trying Lynx with Tor's SOCK5 proxy:
  lynx -dump -socks5_proxy=localhost:9050
      
https://www.bbcweb3hytmzhn5d532owbu6oqadra5z3ar726vq5kgwwn6aucdccrad.onion/

(the BBC Homepage), I got a strange crash for this code:
   socks5_protocol = HTSprintf0(NULL,
                                gettext("(for %s at %s) SOCKS5"),
                                protocol, socks5_host);

A NULL-ptr read which I fail to understand.

But simply replacing with:
   char socks5_buf [1000];
   ...
   snprintf(socks5_buf, sizeof(socks5_buf),
            gettext("(for %s at %s) SOCKS5"), protocol, socks5_host);
   protocol = socks5_buf;

plus some other patches to HTTCP.c (attached), Lynx+Tor
works on Windows-10. The diff is against the 2.9.0dev.10
version. Latest I believe (?)

--
--gv

HTTCP.c.diff
Description: Text document