Re: Preliminary log matching support (the third)

[Christian Hopp]

On Wed, 3 Aug 2005, Jan-Henrik Haukeland wrote:

> On 3. aug. 2005, at 17.37, Martin Pala wrote:
>
> > Looks good :)
>
> Agree, but run the doc through a spell-checker before checkin :)
>
> > Can you send it to cvs? ... here is my +1 ;)
>
> Mine too +1 _when_ the remaining issues are solved. Important! are there some 
> way to optimize the matching process? Using 6 sec parsing 400 lines are to 
> much! It may screwup the monit cycle. And at least 400 lines are to be 
> expected when a couple of log-files are parsed on a normally stressed system. 
> As you know from Perl or Pyton, using a badly written regular expressions can 
> impact performance considerably. So it's an idea to look at the regex also 
> and see if the problem lays there as well..

Well it takes 6s to check 800regex for 400lines (at a max 320000 checks). 
I would advise to have less regexes. (:

The straight forward implementation was to test the ignores first.  If 
they pass check for the "if" clauses.  Well depending on having more "if" 
or "ignores" you would need to check one first.

> > Btw. regarding the regex library - i think that the system library 
> > (standard libc) is sufficient (it is conforming to POSIX).
> > I'm not sure whether there is some advantage when we will bundle the 
> > optional regex library with monit?
>
> I'm not sure, but there may be some (old) systems that provide the regex 
> library outside of libc. Anyway I agree that we should *not* bundle a 
> separate regex package with monit. Configure will find any external regex lib 
> and if it's not on the system we have fall-back options to standard string 
> match. Together this should be enough.

Yep, good idea.  But matching needs to be ported to strings.  Right now it 
won't start if you didn't compile monit with regex support and have a 
match statement in your monitrc.

Christian

--
Christian Hopp                                email: address@hidden
Institut für Elektrische Informationstechnik             fon: +49-5323-72-2113
TU Clausthal, Leibnizstr. 28, 38678 Clausthal-Zellerf.   fax: +49-5323-72-3197
                             pgpkey: https://www.iei.tu-clausthal.de/pgp-keys/