Re: [Monotone-devel] 216 invalid_--root_settings FAIL (line 13)

[Thomas Keller]

Tobias Hunger schrieb:
> Then I set --root to /tmp:
> 
>> /tmp/release/mtn/mtn --norc 
>> --root=/tmp/release/mtn/tester_dir/invalid_--root_settings 
>> --confdir=/tmp/release/mtn/tester_dir/invalid_--root_settings --rcfile 
>> /tmp/release/mtn/tester_dir/invalid_--root_settings/test_hooks.lua 
>> --db=/tmp/release/mtn/tester_dir/invalid_--root_settings/test.db --keydir 
>> /tmp/release/mtn/tester_dir/invalid_--root_settings/keys address@hidden 
> status --root /tmp
> Current branch: testbranch
> Changes against parent
>   no changes
>> ls -alF /tmp/_MTN
> ls: /tmp/_MTN: No such file or directory
> 
> As you can see from the ls there is no _MTN directory in /tmp.
> 
> So I tried using a different directory (/usr):

I have to excuse for this quickshot. After reading again the section
"Finding a workspace" here [0] and looking at the option's description,
I think we all understood this option wrong. What --root does is that it
makes monotone stop looking for a workspace while recursively looking at
the parent directories of the current directory.

So, if your workspace is somewhere under /tmp and you set --root to
/tmp, this means that it stops there, but at this point it already found
the _MTN directory in
/tmp/release/mtn/tester_dir/invalid_--root_settings. As this test wants
to let the search fail (at least this is what I understood, one may
correct me here at any time), we need to make sure that it stops
earlier. The best way to do this is imho creating a new tmp dir in the
tester dir, cd to it and --root to it. Then we should be safe from any
"side effects" which should make this test fail.

Thomas.

[0] http://monotone.ca/monotone.html#Restrictions

-- 
only dead fish swim with the stream: http://thomaskeller.biz/blog
Am Anfang war das Wort: http://www.schäuble-muss-weg.de

signature.asc
Description: OpenPGP digital signature