monotone-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] git fast-export


From: Felipe Contreras
Subject: Re: [Monotone-devel] git fast-export
Date: Thu, 22 Jan 2009 00:17:14 +0200

On Sun, Jan 18, 2009 at 9:40 PM, Derek Scherger <address@hidden> wrote:
>
> On Sun, Jan 18, 2009 at 12:26 AM, Felipe Contreras
> <address@hidden> wrote:
>>
>> True. Then the issue is with my script (ruby date parsing).
>>
>> It looks like I would have to re-generate my repo clone (yay for one
>> whole day of conversion) for the comparison.
>>
>> Before I do that, can we agree on a format for unknown committers?
>
> Is there anything wrong with what I have now, which I think should be
> "unknown <unknown>"? If you want something else use the --authors-file and
> set 'unknown = Unknown <foobar>'

Since I'll be re-generating the repo with my script once more, I'll
follow you convention.

However, I found some issues:

1) no author

Where is no author it appears as "unknown<unknown>"; it's missing a
space and I think first-letter capitalization looks better for names
("Unknown").

2) no name

As discussed before I prefer "Unknown <address@hidden>" but your approach
("<address@hidden>") is not bad.

3) no email

When there's no email I get "Name<unknown>"; it's missing a space.

I really don't like 1), there is *always* a committer in mtn. I
propose to use the first committer of the changelog cert as the git
committer, and then, if there's no mtn author, use the same committer
as author.

Anyway, I'll try to simulate that behaviour so I can make an exact
comparison of the repos.

Cheers.

-- 
Felipe Contreras




reply via email to

[Prev in Thread] Current Thread [Next in Thread]