monotone-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] heads up: file system changes


From: Stephen Leake
Subject: Re: [Monotone-devel] heads up: file system changes
Date: Thu, 24 Sep 2009 04:12:27 -0400
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (windows-nt)

Stephen Leake <address@hidden> writes:

> Zack Weinberg <address@hidden> writes:
>
>> Closely related question: what the hell is going on with
>> new_optimal_path?  AFAICT all users of that function ought to be using
>> system_path, full stop.
>
> The key issue is what root a relative path is relative to.
>
> system_path constructors assume the input path is relative to the
> original process directory. But I needed a path that is relative to
> the workspace root, when reading from a stored conflicts file.

I remembered the rest of the reason. If the user provides a relative
path in a conflict file, then I want to write out that same relative
path when I update the conflict file.

On the other hand, if the user path is absolute, and not in the
workspace, I need to be able to represent that as well.

So I need as_external() to dispatch on the path type when writing a
path to a conflict file.

-- 
-- Stephe




reply via email to

[Prev in Thread] Current Thread [Next in Thread]