Re: [Monotone-devel] heads up: file system changes

[Zack Weinberg]

On Wed, Sep 23, 2009 at 8:02 AM, Daniel Atallah
<address@hidden> wrote:
>
> Interestingly in platform.hh there is a comment stating that the
> "path" argument to do_remove()  "must be a file, not a directory", but
> that appears to not be correct - is that correct or not?

That comment is wrong.  Platform independent code assumes that
do_remove can delete directories.

> The approach that things like Glib use is to ensure consistency within
> the API (all paths are UTF-8); then wherever direct interaction with
> the filesystem occurs, the path is converted to the relevant encoding
> (in the Windows case, this is conversion to a UTF-16 wchar*).  I think
> this is the right way to do it.

This is what our paths.cc / fs.cc layer is trying to do, although it
does have a lot of bugs.

zw