Re: [Nano-devel] Old patch, updated to new CVS.

[David Benbennick]

On Thu, Aug 22, 2002 at 07:46:11PM -0700, David Lawrence Ramsey wrote:
>                                ... First, the assert()
> calling check_linenumbers() is #defined out if NDEBUG isn't
> defined; I know the assert() gets commented out when
> NDEBUG is defined, but apparently the reference to
> check_linenumbers() isn't ...
> 
>      ...  One question, though: what are the config.h
> changes for?  They don't apply to my ./configure-generated
> config.h, but don't seem to make any difference on my
> system either.

Sorry for the config.h.  I use my own, and I forgot to take it out of the
patch.

About assert(): The problem was that, in winio.c, assert.h was included
before config.h.  So in assert.h, NDEBUG was not defined, and assert() got
defined to test its argument.  Then NDEBUG was defined, so
check_linenumbers() didn't exist.  I didn't see this problem before since I
use a different config.h, and define NDEBUG in my Makefile.

The new version, http://www.math.cornell.edu/~dbenbenn/nano/quote31.diff,
has config.h moved to the top of the include list in winio.c, rcfile.c, and
utils.c, to match the other five source files.  Now, with NDEBUG defined in
config.h, asserts are really turned off, and the binary is (for me, after
stripping) another 2K smaller.

Also, I merged your patch changing the die() message and fixing label
spacing.  Thanks for catching those.

pgpBHP6c_w7V9.pgp
Description: PGP signature