[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #39532] hgload/hgsave functions missing
From: |
Pantxo Diribarne |
Subject: |
[Octave-bug-tracker] [bug #39532] hgload/hgsave functions missing |
Date: |
Wed, 05 Mar 2014 10:07:15 +0000 |
User-agent: |
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:27.0) Gecko/20100101 Firefox/27.0 |
Follow-up Comment #5, bug #39532 (project octave):
Yours patches look good. Here is a fast review:
* hgsave:
** "print_usage ()" will return to prompt so no need to make an else
statement,
** instead of "handle = gcf()" (wich will create a new figure if none exist)
use "h = get (0, "currentfigure)" and test. If h is empty prompt an error
message
** I never used the '-struct' modifier in save and I may be misreading the
doc, but I don't see any interest for this purpose.
* hgload:
** same remark about"print_usage ()"
** the way you load the file doesn't work. It results in a structure
"hdlstruct" which has one filed "hdlstruct" which itself contains the
structure you want to send to struct2hdl.
** manage file extension.
For the last point, maybe we should choose a default extension for octave
figures (say .ofig) so that we could fire a warning when somebody tries to
load a '.fig' that probably comes from matlab hgsave (which will fail).
Somebody has an opinion about this?
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?39532>
_______________________________________________
Message posté via/par Savannah
http://savannah.gnu.org/
- [Octave-bug-tracker] [bug #39532] hgload/hgsave functions missing, Pantxo Diribarne, 2014/03/04
- [Octave-bug-tracker] [bug #39532] hgload/hgsave functions missing, Ouzounis Georgios, 2014/03/04
- [Octave-bug-tracker] [bug #39532] hgload/hgsave functions missing, Pantxo Diribarne, 2014/03/04
- [Octave-bug-tracker] [bug #39532] hgload/hgsave functions missing, Massimiliano Fasi, 2014/03/05
- [Octave-bug-tracker] [bug #39532] hgload/hgsave functions missing,
Pantxo Diribarne <=
- [Octave-bug-tracker] [bug #39532] hgload/hgsave functions missing, Pantxo Diribarne, 2014/03/05
- [Octave-bug-tracker] [bug #39532] hgload/hgsave functions missing, Massimiliano Fasi, 2014/03/05
- [Octave-bug-tracker] [bug #39532] hgload/hgsave functions missing, Pantxo Diribarne, 2014/03/06
- [Octave-bug-tracker] [bug #39532] hgload/hgsave functions missing, Massimiliano Fasi, 2014/03/06
- [Octave-bug-tracker] [bug #39532] hgload/hgsave functions missing, Pantxo Diribarne, 2014/03/06
- [Octave-bug-tracker] [bug #39532] hgload/hgsave functions missing, Massimiliano Fasi, 2014/03/06
- [Octave-bug-tracker] [bug #39532] hgload/hgsave functions missing, Rik, 2014/03/20
- [Octave-bug-tracker] [bug #39532] hgload/hgsave functions missing, Rik, 2014/03/21
- [Octave-bug-tracker] [bug #39532] hgload/hgsave functions missing, Massimiliano Fasi, 2014/03/25