[Octave-bug-tracker] [bug #42490] helpdlg does not return a proper graphics handle

[Dan Sebald]

Follow-up Comment #9, bug #42490 (project octave):

The patch reports:


@linux ~/octave/octave/octave $ patch -p1 <
~/octave/bug/42490/msgbox_fig4.patch 
patching file libgui/graphics/BaseControl.cc
patching file libgui/src/octave-qt-link.cc
patching file libgui/src/octave-qt-link.h
patching file libinterp/corefcn/octave-link.cc
patching file libinterp/corefcn/octave-link.h
File scripts/gui/__error-icon__.png: git binary diffs are not supported.
File scripts/gui/__help-icon__.png: git binary diffs are not supported.
File scripts/gui/__warn-icon__.png: git binary diffs are not supported.
patching file scripts/gui/errordlg.m
patching file scripts/gui/helpdlg.m
patching file scripts/gui/module.mk
patching file scripts/gui/msgbox.m
patching file scripts/gui/warndlg.m


and later there is a compile error:


make[2]: *** No rule to make target 'scripts/gui/__error-icon__.png', needed
by 'all-am'.  Stop.
make[2]: *** Waiting for unfinished jobs....
  GEN      build-aux/subst-script-vals.sh


I created some empty files:


touch scripts/gui/__error-icon__.png
touch scripts/gui/__help-icon__.png
touch scripts/gui/__warn-icon__.png


which creates its own problems:


>> demo msgbox
msgbox example 1:
 msgbox ("A bare dialog");

Press <enter> to continue:
msgbox example 2:
 msgbox ("An informative string", "Documentation", "help");

msgbox example 2: failed
Magick++ exception: Magick: Improper image header
(/home/sebald/octave/octave/octave/scripts/gui/__help-icon__.png) reported by
coders/png.c:2673 (ReadPNGImage)


in which no message box appears when there is an error reading the PNG.  The
message box should still appear but just a blank icon.

Also, do something like the following:


>> figure(1)
>> h1 = plot(1:50);
>> figure(2)
>> h2 = plot(50:-1:1);
>> demo msgbox
msgbox example 1:
 msgbox ("A bare dialog");

Press <enter> to continue:


and the Figure 1 contents goes blank.  The Figure 2 is usurped by the message
box and eventually deleted on close.

Rerunning the "demo msgbox", if I type return real quickly multiple message
boxes will appear.  So that makes me wonder about the following:


>> h1 = msgbox("Msg 1", "title 1", "none", "modal"); h2 = msgbox("Msg 2",
"title 2", "none", "modal");


The message boxes do appear to be modal, but I wonder if msgbox 1 should
appear as modal and wait for response, then after that display msgbox 2 and
wait for response.

In any case, I really don't know if this is the way to go.  Don't we want the
message boxes to have the look and feel of the GUI, e.g., the "demo listdlg"
and "demo questdlg"?  The msgbox objects, being like figures, can be resized
resulting in odd effects.  Compare that with the questdlg and listdlg which
can't be resized.  I understand that the proposed approach utilizes the
underlying handle-graphics, which is good in a way, but can't it be made to
use the default Qt system icons, which ultimately go back to the system
icons?


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?42490>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/