Re: function definitions in tests

[John W. Eaton]

On 18-Jan-2010, David Grundberg wrote:

| This might have to do with changes I did to the interpreter (after 3.2). 
| I know I changed eval_string() to require function definitions to have 
| endfunctions. I think this is a good thing when calling eval.m. But with 
| tests, the block is defined by the indention and that should suffice. 
| I'm pushing a changeset to fix this.
| 
| http://hg.savannah.gnu.org/hgweb/octave/rev/e68431e60e3d

But now there will be failures if the test includes an explicit
endfunction, because you have added one unconditionally.

Perhaps we should just fix the tests so that they have explicit
endfunction tokens, or look for some other solution to the problem?
If the tests fail when run from the command line, why do they succeed
when run as part of make check?  What is the difference between those
two cases?

Also, in ChangeLog entries, please write what has changed, not just
that something has changed or was fixed.  For example, instead of

  * testfun/test.m: Fix !function test blocks.

or

  * mex.cc (mexPrintf): Change signature.
  * mexproto.h (mexPrintf): Dito.

perhaps

  * testfun/test.m: Append endfunction to !function test blocks.

and

  * mex.cc (mexPrintf): Return int value from octave_vformat.
  * mexproto.h (mexPrintf): Fix decl to match new signature.

If all ChangeLog entries said only "fixed bug" or "changed fcn" then
they would not be useful at all.

Thanks,

jwe