octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 'noreturn' warning in libcruft


From: John W. Eaton
Subject: Re: 'noreturn' warning in libcruft
Date: Tue, 7 Aug 2012 15:21:33 -0400

On  7-Aug-2012, Michael Goffioul wrote:

| That's consistent with what's in dumped into config.h (we don't test for the
| feature, it's solely based on __GNUC__ definition).

I think it was probably done that way out of laziness.  I hesitate to
test for __GNUC__ in more places.  I think it would be better to use
HAVE_ATTR_NORETURN, even if that is (due to more laziness) also
defined in the config.h header based solely on __GNUC__.  Maybe also
we should rename the HAVE_GCC_ATTR_NORETURN to be HAVE_ATTR_NORETURN,
since this might eventually be a feature of more than one compiler.

jwe


reply via email to

[Prev in Thread] Current Thread [Next in Thread]