Re: Success of 2015 Code Sprint

[Rik]

On 12/19/2015 11:06 AM, Andreas Weber wrote:
> Am 15.12.2015 um 21:11 schrieb Rik:
>> We had a very successful code sprint last Saturday.  Thanks to everyone
>> involved we managed to tackle and complete 5 of 6 topics.  Should we make
>> this a more regular thing, maybe semi-annual instead of just annual? 
> Hi Rik. First thank you for the great preparation (for example the wiki
> pages). I think we should make a Code Spint more often, 2 or 4 a year.
> Perhaps we could also make a list with easy clean-up tasks which can be
> done without a CodeSprint?
>
> For example removing the
>
> bool success = true;
> ...
> {
>   error (..)
>   success = false;
> }
> ...
> return success;
>
> constructs.
>
> Or is there a reason to keep these?

Andy,

I'm cleaning up my e-mail and came across this unread one from you.  Yes,
this would be a good idea to clean up these easy instances.  Most of the
time I think you can just eliminate the variable declaration and "return
true" at the end of the function if execution has made it that far.  The
code base has changed a bit so I did a new grep for 'success =' to get a
list of instances.

--Rik

corefcn/ls-mat-ascii.cc:350:  bool success = true;
corefcn/ls-mat-ascii.cc:365:      success = false;
corefcn/ls-oct-text.cc:304:  bool success = true;
octave-value/ov-base-diag.cc:499:  bool success = true;
octave-value/ov-base-int.cc:208:  bool success = true;
octave-value/ov-base-sparse.cc:447:  bool success = true;
octave-value/ov-bool-mat.cc:218:  bool success = true;
octave-value/ov-class.cc:1308:  bool success = true;
octave-value/ov-class.cc:1373:          success = false;
octave-value/ov-cx-mat.cc:354:  bool success = true;
octave-value/ov-fcn-handle.cc:254:  bool success = true;
octave-value/ov-fcn-handle.cc:386:  bool success = true;
octave-value/ov-fcn-handle.cc:483:                success = false;
octave-value/ov-fcn-handle.cc:486:            success = false;
octave-value/ov-fcn-handle.cc:489:        success = false;
octave-value/ov-fcn-handle.cc:564:  bool success = true;
octave-value/ov-fcn-handle.cc:658:                success = false;
octave-value/ov-fcn-handle.cc:661:            success = false;
octave-value/ov-fcn-handle.cc:924:  bool success = true;
octave-value/ov-fcn-handle.cc:1096:            success = false;
octave-value/ov-fcn-handle.cc:1167:                success = false;
octave-value/ov-fcn-handle.cc:1170:            success = false;
octave-value/ov-fcn-handle.cc:1205:            success = false;
octave-value/ov-fcn-handle.cc:1214:                success = false;
octave-value/ov-fcn-handle.cc:1234:                success = false;
octave-value/ov-fcn-handle.cc:1243:                    success = false;
octave-value/ov-flt-cx-mat.cc:328:  bool success = true;
octave-value/ov-flt-re-mat.cc:352:  bool success = true;
octave-value/ov-perm.cc:286:  bool success = true;
octave-value/ov-re-mat.cc:454:  bool success = true;
octave-value/ov-str-mat.cc:327:  bool success = true;
octave-value/ov-struct.cc:703:  bool success = true;
octave-value/ov-struct.cc:728:    success = false;
octave-value/ov-struct.cc:813:  bool success = true;
octave-value/ov-struct.cc:875:    success = false;
octave-value/ov-struct.cc:1366:  bool success = true;
octave-value/ov-struct.cc:1437:  bool success = true;
octave-value/ov-struct.cc:1474:    success = false;