Re: [pdf-devel] New functions for the Time Module

[Aleksander Morgado]

>    address@hidden pdf_status_t pdf_time_set_from_i32 (pdf_time_t
>    @var{time_var}, pdf_i32_t @var{seconds})

I was thinking in using `pdf_i64_assign_quick' internally, which takes a 
signed 32-bit integer. We don't have an equivalent function for 
pdf_u32_t. Or... we can use directly pdf_i64_assign(var,0,u32) true?
I'll check it.

>    address@hidden pdf_status_t pdf_time_set (pdf_time_t @var{time_var},
>    pdf_i64_t @var{seconds})
>
> Why are we using signed values for the parameters?

The same for pdf_i64_t. We don't have a pdf_u64_t, and I don't see any 
easy hack for this.


> Also, I would name the second function as 'pdf_time_set_from_i64'. It
> is more explicit.

I was trying to follow the same way as with pdf_time_span_t, where we 
have `pdf_time_span_set' to set from i64, and 
`pdf_time_span_set_from_i32' for i32. But could even be a good idea 
renaming also the `pdf_time_span_set' function to 
`pdf_time_span_set_from_i64'.

-Aleksander