Re: [Phpgroupware-developers] Database reengineering completed

[Dave Hall]

Kai Hofmann <address@hidden> wrote:

> Hello all!
> 
> I have completet the database analysis of the phpGroupware HEAD I 
> checkedout at 2003-04-12.
> You can download the graphical schema including relations I 
> extracted from
> the source code (8*3 DIN A4 pages)
> as well as the database report with (SQL) references from the php 
> sourcecode to the database tables, at:
> 
> http://www.probusiness.de/projekte/phpgroupware/database.html
> 
> 
> The bugs I have found here will be send first to the core team!

Why not log them as bug reports on savannah like other users?

> 
> Maybe there are more relations that are only used within the API 
> but not via
> SQL SELECT statements. These are
> not within the diagramm yet!


There are many relations which are not used within SQL - as they may be
relations with ldap or imap etc ...

It looks like you spent a lot of time on this, but some of it would
appear to be wasted.  You have documented unsupported apps or apps which
are currently under review or active development.  

For example a quick look at the skel app would reveal that the it is a
skeleton app ... which is never designed to be run ... but in fact
designed to give potential developers some idea of the structure of a
phpgw app.  

More examples:
* cdb - it has never been completed ... and is unlikely to ever be.
* anglemail - the table is optional
* phpbrain - it will change in the next day or 2

As for the code references:
* app/inc/class.*so*.inc.php
  - most of these should reference the db ... as they are storage objects

* setup/tables_*.inc.php
  - these are schema files so I hope they include references to tables

* 2.181 Table phpgw_lang
  If tables_*.inc.php is listed as referencing tables then every
app/setup/phpgw_*.lang file should also get a mention imho

If nothing else we know where a change to an api table requires code
changes ... but grep would have done that too.

> 
> I am also working on a "SQL style guide" - that will be published 
> soon.

Looking forward to seeing that.

Thought you would appreciate the feedback.

Cheers

Dave

dave.hall.vcf
Description: Card for <dave.hall@mbox.com.au>