phpgroupware-developers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Phpgroupware-developers] phplib template class in HEAD


From: Dave Hall
Subject: [Phpgroupware-developers] phplib template class in HEAD
Date: Sat, 14 Oct 2006 21:48:07 +1000

Hi all,

Some time ago I synced the template class in HEAD with the upstream
version, something which hadn't been done for a very long time.

I have been aware of a major down side of this change, that being it
breaks some templates.  The regex matching of the new template class is
stricter than the hacked up version we have used in <= 0.9.16.  I have
not had time to look into fixing as yet.

The main thing which is broken is setup and admin where we use more than
0-9a-Z_ (and a few other characters) as the template variables.  I
personally would like to took at simplify the text used in admin and
setup to make it clearer for users and so possibly reduce the need for
additional characters.  What do you think?  Also are you willing to get
your hands dirty to help with the fixes?

I also hope to move our remaining hacks out of the class so we have
phpgwapi/inc/class.Template.inc.php which extends
phpgwapi/inc/phplib/class.Template.inc.php  This change should make
syncing with upstream easier.

Cheers

Dave
-- 
Dave Hall (aka skwashd)
API Coordinator
phpGroupWare
e address@hidden
w phpgroupware.org
j address@hidden
sip address@hidden
       _            ____                    __        __             
 _ __ | |__  _ __  / ___|_ __ ___  _   _ _ _\ \      / /_ _ _ __ ___ 
| '_ \| '_ \| '_ \| |  _| '__/ _ \| | | | '_ \ \ /\ / / _` | '__/ _ \
| |_) | | | | |_) | |_| | | | (_) | |_| | |_) \ V  V / (_| | | |  __/
| .__/|_| |_| .__/ \____|_|  \___/ \__,_| .__/ \_/\_/ \__,_|_|  \___|
|_|         |_|                         |_|Web based collaboration platform






reply via email to

[Prev in Thread] Current Thread [Next in Thread]