Re: [Phpgroupware-developers] phplib template class in HEAD

[Chris Weiss]

hm.  i'm torn on some of this.

on restricting the regex:
on one side, restricting the "key" characters so that you have to use
a "key phrase" instead of a "default translation" like we have now can
make translating easier since unknowns will stand out more strongly
(not just and * but also not a proper sentance).

on the other, having a "default translation" as the key can make
development a lot simpler since you'll have a usable site whether or
not you have bother to enter the primary language.


on changing our "style":
what are the drawbacks of allowing any character in the key?  does it
make the translations notably slower?

And, could we submit a patch upstream to make it so a developer can
choose a limited regex like the new one or a more complex one like
ours?  it seems like, short term anyway, this would be a lot easier to
do, and we can worry about our "style" after 1.0 when i'm hoping a lot
of the UI will be changed anyway.


On 10/14/06, Dave Hall <address@hidden> wrote:
> Hi all,
>
> Some time ago I synced the template class in HEAD with the upstream
> version, something which hadn't been done for a very long time.
>
> I have been aware of a major down side of this change, that being it
> breaks some templates.  The regex matching of the new template class is
> stricter than the hacked up version we have used in <= 0.9.16.  I have
> not had time to look into fixing as yet.
>
> The main thing which is broken is setup and admin where we use more than
> 0-9a-Z_ (and a few other characters) as the template variables.  I
> personally would like to took at simplify the text used in admin and
> setup to make it clearer for users and so possibly reduce the need for
> additional characters.  What do you think?  Also are you willing to get
> your hands dirty to help with the fixes?
>
> I also hope to move our remaining hacks out of the class so we have
> phpgwapi/inc/class.Template.inc.php which extends
> phpgwapi/inc/phplib/class.Template.inc.php  This change should make
> syncing with upstream easier.
>
> Cheers
>
> Dave
> --
> Dave Hall (aka skwashd)
> API Coordinator
> phpGroupWare
> e address@hidden
> w phpgroupware.org
> j address@hidden
> sip address@hidden
>        _            ____                    __        __
>  _ __ | |__  _ __  / ___|_ __ ___  _   _ _ _\ \      / /_ _ _ __ ___
> | '_ \| '_ \| '_ \| |  _| '__/ _ \| | | | '_ \ \ /\ / / _` | '__/ _ \
> | |_) | | | | |_) | |_| | | | (_) | |_| | |_) \ V  V / (_| | | |  __/
> | .__/|_| |_| .__/ \____|_|  \___/ \__,_| .__/ \_/\_/ \__,_|_|  \___|
> |_|         |_|                         |_|Web based collaboration platform
>
>
>
>
> _______________________________________________
> Phpgroupware-developers mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/phpgroupware-developers