Re: MustuxAudioFileFormat Was: [Protux-devel] ugly click on wav output

[Martin Herren]

On Sat, 14 Feb 2004 21:19:18 +0100
Martin Herren <address@hidden> wrote:

> Hej,
> 
> i noticed a few strange things in MustuxAudioFileFormat:
> 
>  - PrafFile::create() doesn't call write_header(), while WavFile::create() 
> does it with default values...
> The behavior of this 2 calls should be the same. The question is now whether 
> write_header() should be called. I think it's a good thing, but the values 
> given to write_header() should also be optional arguments to create().
> Furthermore i see no reason to have these calls implemented in PrafFile:: and 
> Wavfile::, one implementation in MustuxAudioFileFormat:: should be sufficent.
> 
>  - read_header() does not jump to the begining of audio data... should it 
> (with a skip_header for example) ? I think that's the behavior that would be 
> expected from the function name... i already did this mistake in praf ;-)
> 
>  - a few other thing could be done in MustuxAudioFileFormat::, while staying 
> virtual in case they should be overriden one day.
> 
> so RFC... i could take care of these once a design desision is taken.

no comments ???

pgpEvq0yZSNAw.pgp
Description: PGP signature