Re: GNU PSPP 0.6.2-pre6 now available

[Ben Pfaff]

I took a quick look at this tonight.

There are errors in 4 functions in lib/gtksheet/gtkitementry.c.
At first glance, I do not think that any of them is very
difficult to fix:

        - gtk_entry_real_insert_text: I suspect that this
          function could essentially be replaced by a single call
          to gtk_entry_buffer_insert_text in the later GTK+.

        - gtk_entry_real_delete_text: Ditto, with
          gtk_entry_buffer_delete_text.

        - gtk_entry_retrieve_surrounding_cb: I think that this
          function could use gtk_entry_buffer_get_text and
          gtk_entry_buffer_get_bytes.

        - gtk_entry_create_layout: Ditto, plus the call to
          g_utf8_strlen could become a call to
          gtk_entry_buffer_get_length.

I don't have time tonight to explore further.

John Darrington <address@hidden> writes:

> [ dropping address@hidden from this thread. ]
>
> It seems that for some reason, the Gtk guys have renamed
> some of their variables.  Obviously, it's not a good thing 
> that we're using private variables of the Gtk+ library in the
> first place - fortunately, in the master branch, this whole 
> offending file has been removed.
>
> However, I'm not sure what the best solution for 0.6.x will be.
>
> J'
>
> On Mon, Sep 14, 2009 at 12:15:19PM +0000, Matej Cepl wrote:
>      John Darrington, Mon, 14 Sep 2009 18:44:07 +0800:
>      
>      > What version of Gtk+ are you building against?
>      
>      gtk2-devel-2.17.11-2.fc12.x86_64
>      (current in Fedora Rawhide)
>      
>      Mat??j
>      
>      
>      
>      _______________________________________________
>      pspp-dev mailing list
>      address@hidden
>      http://lists.gnu.org/mailman/listinfo/pspp-dev

-- 
Ben Pfaff 
http://benpfaff.org