Re: Building 0.6.2 against Gtk+ 2.17.11

[John Darrington]

On Wed, Sep 16, 2009 at 10:19:21PM -0700, Ben Pfaff wrote:
     Matej Cepl <address@hidden> writes:
     
     > John Darrington, Tue, 15 Sep 2009 19:25:19 +0800:
     >> It's probably not ultra difficult, but it's more than a simple wrapper
     >> as I had hoped.  It's complex enough that it'll need to be developed on
     >> a system loaded with the new Gtk+ version that's causing the problems,
     >> and tested to make sure it's not broken.
     >
     > If you throw any patch in my direction I am willing to test it/fix it/
     > finalize it, just I don't want to study all Gtk+ documentation on my own 
     > now.
     
     Here's a patch for testing.  It works for me.

     John: would you mind applying this patch and verifying that I
     didn't break anything with earlier GTK+ versions?  Also--is it a
     sufficient test to add a few variables in the variable sheet and
     then put a couple of values in each?  That's what I did, anyhow.
     
To build I had to add the following code:

#if ! GTK_CHECK_VERSION (2,14,0)
static guint16
gtk_entry_get_text_length (GtkEntry *entry)
{
  return entry->text_length;
}
#endif

Otherwise, I didn't notice any problem.

Regarding testing, you should also make sure that hitting the <Del> key
in one  of the cells in the data sheet does something sensible.  
In the stable branch, it simply clears the cell ready for new input, but
doesn't actually update any value.  This behaviour is changed in 0.7.x which
replaces the value with SYSMIS.

J'


     


-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.

signature.asc
Description: Digital signature