Re: Ext2 bugfixes

[Marco Gerards]

Jeroen Dekkers <address@hidden> writes:

> On Sat, Nov 08, 2003 at 06:16:39PM +0100, Marco Gerards wrote:
> > Jeroen Dekkers <address@hidden> writes:
> > >   (pupa_ext2_open): Check if data isn't null before calling pupa_free.
> > >   (pupa_ext2_dir): Likewise.
> > 
> > I see no reason for this.  pupa_free won't do a thing when data is null.
> 
> It doesn't in pupa util things, see util/misc.c.

AFAIK free works like this, no need to add such check to util/misc.c.
On my GNU/Linux system this is explained in "man 3 free",
unfortunately I can't find any information about this in the glibc
manual.  IMHO util/misc.c should be changed if it doesn't work
correctly.
  
> > > 2003-10-30  Jeroen Dekkers  <address@hidden>
> > > 
> > >   * fs/ext2.c (struct pupa_ext2_inode): Declare struct datablocks
> > >   as blocks.
> > >   (pupa_ext2_get_file_block): Use blocks member.
> > 
> > I should have done this in the first place but I didn't have gcc 2.95
> > around.  Have you tried to compile this on gcc 2.95?  Did you test
> > this patch before sending it in (by booting GNU/Linux from ext2fs for
> > example)?
> 
> I have tested a lot with it (probably more than you :P). I didn't try
> compiling with 2.95 as I don't have it installed. I don't see why that
> is needed because it's just normal C.

Ok.

Thanks,
Marco